Skip to content

Conversation

@0x70b1a5
Copy link
Contributor

@0x70b1a5 0x70b1a5 commented Sep 3, 2025

Problem

  1. feature: links to other apps #811
  2. hitting Refresh on an open app closes the app

Solution

  1. implement feature: links to other apps #811
  2. read the #url-hash if present to attempt to find an app to open on refresh

Testing

#811

  • open the Appstore Widget. Click a listing - they use hw:// links now.
  • Verify the app listing click opens the appstore page of the respective app.
  • Without closing the appstore, proceed immediately to the next set of tests.

Reloads

  • Hit Refresh, CTRL+R or F5.
  • Verify that the appstore reopens to the main appstore page on the page reload. (sub-page nav is something i'd like to add later on if needed - it's possible for the appstore we have but it may not be desired in the fully general case of all webapps.)

Copy link
Member

@nick1udwig nick1udwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work

I have a small nit for you to look at before merge:

  • Click an app in widget
  • App Store properly opens to that app's page
  • Click to go to App Store home
  • Click action button and go to home screen (leaving App Store open on the home page)
  • Click on an app in widget
  • App Store opens, but not to the app's page: instead just to the homepage

Is this intended or expected behavior? Is it easy to fix?

@0x70b1a5
Copy link
Contributor Author

0x70b1a5 commented Sep 4, 2025

@nick1udwig It should work now. There's a trade-off here where I believe the issue is:

  • the homepage only has control over the iframe's top-level src attr
  • the homepage does NOT have the ability to manipulate child SPA paths js-wise
    • such a thing could be done, but it'd involve more iframe message passing and hw:// library updates
  • anyway, changing this src attr does indeed "navigate" the iframe (by causing it to entirely reload)
  • this results in a slow, but adequate, completion of the desired action

I vote "make it exist first, make it good later" here, personally. If we need lightning fast intra-app switching via external link clicks, it might be better to put the work into it once there is a solid user story informed by the need.

@nick1udwig
Copy link
Member

@0x70b1a5 not going to hold up the PR on this, but there is still one edge case, see #843

@nick1udwig nick1udwig merged commit a8f6b36 into develop Sep 5, 2025
1 check passed
@nick1udwig nick1udwig deleted the tm/app-protocol-links branch September 5, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants