Skip to content

Conversation

@sinh117801
Copy link
Contributor

  • upgrade jest and fixed som error on test after upgrade. REF: #2533
  • upgrade size-limit reduce the size from 2.55KB to 2.11KB after build.

@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #869 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #869   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          164       164           
  Lines         1319      1319           
  Branches       273       273           
=========================================
  Hits          1319      1319           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3188e15...8276f26. Read the comment docs.

@iamkun
Copy link
Owner

iamkun commented Apr 16, 2020

The new version would cause an npm install error on node 6.

Besides, I don't think upgrade size-limit reduce the size from 2.55KB to 2.11KB after the build. is really reduce the bundle size. Instead, it may just adjust its calculation algorithm?

@sinh117801
Copy link
Contributor Author

@iamkun, just a question. When will you plan to stop support node 6?

@iamkun
Copy link
Owner

iamkun commented Apr 16, 2020

there's no need to stop support node 6, make be just a time to skip unit test on node 6

@sinh117801
Copy link
Contributor Author

Ok, I see. I will close this PR.

@sinh117801 sinh117801 closed this Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants