Skip to content

Conversation

@axunonb
Copy link
Collaborator

@axunonb axunonb commented Nov 5, 2024

  • No changes in code logic
  • Store files with utf8 encoding (set with .gitattributes, rewrite existing files)
  • Update solution to file-scoped namespace
  • Update .editorconfig and apply rules

* No changes in code logic
* Store files with utf8 encoding (set with .gitattributes, rewrite existing files)
* Update .editorconfig and apply rules
@axunonb axunonb force-pushed the pr/gitattributes-editorconfig branch from d35b827 to dfad131 Compare November 11, 2024 21:10
@sonarqubecloud
Copy link

@axunonb
Copy link
Collaborator Author

axunonb commented Nov 11, 2024

@minichma If there's nothing against the 3 changes, I'd like to merge the PR, otherwise close and postpone. It's just standing in the way :)

@minichma
Copy link
Collaborator

Sorry for the delay! I think its good to consistency throughout the code.

@axunonb axunonb merged commit fedbd4f into ical-org:main Nov 12, 2024
3 checks passed
@axunonb axunonb deleted the pr/gitattributes-editorconfig branch November 12, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants