Skip to content

Fix #729: incorrect expansion behaviour after BYWEEKNO #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
axunonb merged 4 commits into from
Feb 20, 2025
Merged

Fix #729: incorrect expansion behaviour after BYWEEKNO #731

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6bb0b2f
Fix #729: incorrect expansion behaviour after `BYWEEKNO`
minichma Feb 15, 2025
405e6e8
Reduce cyclomatic complexity of `GetWeekNoVariants` to make CodeCov a…
minichma Feb 15, 2025
050e753
Make method static to avoid CodeCov complaining.
minichma Feb 16, 2025
62ade45
Merge branch 'main' into work/minichma/bugfix/byweekno_expansion
axunonb Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make method static to avoid CodeCov complaining.
  • Loading branch information
@minichma
minichma committed Feb 16, 2025
commit 050e7534dae40c94468bf029222a8eb6fc8817d6
2 changes: 1 addition & 1 deletion Ical.Net/Evaluation/RecurrencePatternEvaluator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ private List<int> GetByWeekNoForYearNormalized(RecurrencePattern pattern, int ye
/// </summary>
/// <param name="dates">The list of dates to which the BYYEARDAY rules will be applied.</param>
/// <returns>The modified list of dates after applying the BYYEARDAY rules.</returns>
private List<DateTime> GetYearDayVariants(List<DateTime> dates, RecurrencePattern pattern, bool? expand, ref ExpandContext expandContext)
private static List<DateTime> GetYearDayVariants(List<DateTime> dates, RecurrencePattern pattern, bool? expand, ref ExpandContext expandContext)
{
if (expand == null || pattern.ByYearDay.Count == 0)
{
Expand Down
Loading