-
Notifications
You must be signed in to change notification settings - Fork 248
EvaluationOptions: Fix off-by-one issue of MaxUnmatchedIncrementsLimit
#775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❌ Your project status has failed because the head coverage (67%) is below the target coverage (80%). You can increase the head coverage or adjust the target coverage. @@ Coverage Diff @@
## main #775 +/- ##
===================================
Coverage 67% 67%
===================================
Files 104 104
Lines 4490 4490
Branches 1111 1111
===================================
Hits 2998 2998
Misses 1064 1064
Partials 428 428
🚀 New features to boost your workflow:
|
783833a to
6532cca
Compare
|
MaxUnmatchedIncrementsLimitMaxUnmatchedIncrementsLimit
axunonb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good finding, tnx



The evaluation of
EvaluationOptions.MaxUnmatchedIncrementsLimitis off by one, which is fixed by this PR.