-
Notifications
You must be signed in to change notification settings - Fork 248
Make NRT enabled the default setting for projects and CI builds #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make NRT enabled the default setting for projects and CI builds #786
Conversation
* Remove parameter -p:Nullable=disable * Now use setting from project file
|
|
Couldn't yet find a way to get rid of the nullability warnings for |
minichma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats, with all the previous NRT PRs this was a significant piece work. Thanks for the nice commit structure of this one, made the review a breeze.
|
Thanks for the review. The NRT for the ical.net project is finally completed. Implementing NRT for the unit tests is less painful, and we can handle it one file at a time. |



#nullable enableper file with empty stringnullablesetting for all project files (Ical.Net: enable, Ical.Net.Tests: disable)