Skip to content

fix: Evaluation of EXDATE when date-only while DTSTART is date-time #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minichma merged 7 commits into from
Jul 4, 2025
Merged

fix: Evaluation of EXDATE when date-only while DTSTART is date-time #830

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
06cc119
#829: Reproduce issue with date-only EXDATE not being properly consid…
minichma Jul 2, 2025
40af80e
Fix #829: Don't miss date-only EXDATEs on the same date as `periodStart`
minichma Jul 2, 2025
fecb42d
Test: Reproduce issue if EXDATEs of type DATE-only and DATE-TIME are …
minichma Jul 2, 2025
29fd4c4
Evaluation: Fix issue if EXDATEs of type DATE-only and DATE-TIME are …
minichma Jul 2, 2025
095dbb7
Evaluation: Remove unused params `EvaluateExDate(referenceDate)` and …
minichma Jul 2, 2025
a061723
Test: Reproduce issue with DATE-only EXDATEs used with RDATEs in diff…
minichma Jul 3, 2025
3095285
#832: Fix issue with DATE-only EXDATEs used with RDATEs in different TZ
minichma Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix #829: Don't miss date-only EXDATEs on the same date as periodStart
  • Loading branch information
@minichma
minichma committed Jul 2, 2025
commit 40af80eb45403ab1f02e3fd6014d89d5fd4a69aa
9 changes: 8 additions & 1 deletion Ical.Net/Evaluation/RecurringEvaluator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,14 @@ public override IEnumerable<Period> Evaluate(CalDateTime referenceDate, CalDateT
var rdateOccurrences = EvaluateRDate(referenceDate, periodStart);

var exRuleExclusions = EvaluateExRule(referenceDate, periodStart, options);
var exDateExclusions = EvaluateExDate(referenceDate, periodStart);

// EXDATEs could contain date-only entries while DTSTART is date-time. Probably this isn't supported
// by the RFC, but it seems to be used in the wild (see https://github.com/ical-org/ical.net/issues/829).
// So we must make sure to return all-day EXDATEs that could overlap with recurrences, even if the day starts
// before `periodStart`. We therefore start 2 days earlier (2 for safety regarding the TZ).
// DISCUSS: Should we support date-only EXDATEs being mixed with date-time DTSTARTs at all? What
// if one has a time zone and the other doesn't? Many details are unclear.
var exDateExclusions = EvaluateExDate(referenceDate, periodStart?.AddDays(-2));

var periods =
rruleOccurrences
Expand Down