Skip to content

Remove misleading FIXME comment in VTimeZoneInfo #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
axunonb merged 1 commit into from
Oct 7, 2025
Merged

Remove misleading FIXME comment in VTimeZoneInfo #874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions Ical.Net/VTimeZoneInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@ public class VTimeZoneInfo : CalendarComponent, IRecurrable

public VTimeZoneInfo()
{
// FIXME: how do we ensure SEQUENCE doesn't get serialized?
//base.Sequence = null;
// iCalTimeZoneInfo does not allow sequence numbers
// Perhaps we should have a custom serializer that fixes this?

Initialize();
}
public VTimeZoneInfo(string name) : this()
Expand All @@ -41,14 +36,14 @@ private void Initialize()
protected override void OnDeserializing(StreamingContext context)
{
base.OnDeserializing(context);

Initialize();
}

public virtual string? TzId
{
get =>
!(Parent is VTimeZone tz)
Parent is not VTimeZone tz
? null
: tz.TzId;
}
Expand Down
Loading