Skip CalDateTime.Add(Duration) for Empty Durations
#877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a shortcut to bypass the operation when the duration is empty: `if (d.IsEmpty) return this;`
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #877 +/- ##
=====================================
Coverage 68.1% 68.1%
=====================================
Files 115 115
Lines 4353 4354 +1
Branches 1003 1004 +1
=====================================
+ Hits 2966 2967 +1
Misses 1028 1028
Partials 359 359
🚀 New features to boost your workflow:
|
minichma
approved these changes
Oct 19, 2025
This was referenced Nov 13, 2025
This was referenced Nov 24, 2025
This was referenced Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a shortcut to bypass the operation when the duration is empty:
if (d.IsEmpty) return this;Resolves #876