Skip to content

Conversation

@rullzer
Copy link
Contributor

@rullzer rullzer commented Feb 15, 2019

So turns out I was to quick with #8

Fixed now
And adjusted the tests to actually check for this

@coveralls
Copy link

coveralls commented Feb 15, 2019

Coverage Status

Coverage remained the same at 95.413% when pulling 8c45c9a on rullzer:master into e1b5ac1 on icewind1991:master.

@rullzer
Copy link
Contributor Author

rullzer commented Feb 15, 2019

I have no idea why php <7 is failing

@rullzer
Copy link
Contributor Author

rullzer commented Feb 15, 2019

Ok turns out php <7 always reads the chunk size and does other magic in fread.

@icewind1991
Copy link
Owner

you can add a condition for the php version in the test case.

As long as the callback actually gets the number of bytes read it doesn't matter that those values depend on php version

@icewind1991 icewind1991 merged commit 4db3ed6 into icewind1991:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants