For enums, use to_string, from_string. #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgates3
force-pushed
the
to_string
branch
6 times, most recently
from
be1e038 to
980a08d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on icl-utk-edu/testsweeper#21 and icl-utk-edu/blaspp#77
Use standard
to_stringfunction to convert enum to string.Introduce
to_charandto_c_stringfunctions.Introduce
from_stringfunction to convert string to enum.This also makes the ParamEnum constructor much simpler.
Changing the blocksize nb to match SLATE had the side effect of revealing a bug in orhr_col and unhr_col. A work around was added.