Conversation
khaeru
force-pushed
the
ci-2023-W15
branch
2 times, most recently
from
00ecbd8 to
0961947
Compare
Codecov Report
@@ Coverage Diff @@
## main #96 +/- ##
=======================================
Coverage 67.09% 67.09%
=======================================
Files 58 58
Lines 4009 4009
=======================================
Hits 2690 2690
Misses 1319 1319 |
- Transfer flake8 config to .flake8. - Sort [tool.*] sections. - Add classifiers. - Reduce mypy overrides. - Remove workaround for iiasa/ixmp#449. - Remove outdated e-mail address; add maintainers.
glatterf42
approved these changes
Apr 18, 2023
Member
glatterf42
left a comment
glatterf42
left a comment
There was a problem hiding this comment.
Looks good to me, only suggested two changes to https again.
Co-authored-by: Fridolin Glatter <83776373+glatterf42@users.noreply.github.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…by disabling the jobs that rely on the currently installable
ixmp[tests] <= 3.6.0. Ifcodecovis not re-established on PyPI (cf. iiasa/ixmp#477), these could possibly be re-enabled by adjusting to depend onixmponly (not[tests]) and directly specifying here the additional dependencies (exceptcodecov) that would have been brought in byixmp[tests].Along with other housekeeping:
How to review
Read the diff and note that the CI checks all pass.
PR checklist
Add or expand tests;coverage checks both ✅Add, expand, or update documentation.Update doc/whatsnew.