Skip to content

Fix spelling error, bump version to 2.2.2#130

Merged
ikalchev merged 2 commits intoikalchev:devfrom
cdce8p:fix-setup_cfg
May 29, 2018
Merged

Fix spelling error, bump version to 2.2.2#130
ikalchev merged 2 commits intoikalchev:devfrom
cdce8p:fix-setup_cfg

Conversation

@cdce8p
Copy link
Copy Markdown
Contributor

@cdce8p cdce8p commented May 29, 2018

Unfortunately I had wrote date instead of data, which resulted in the wheel being broken again 😞

The upside is that it should work now, which I could test, since I just found out that I had to delete the build directory before I start a new one.

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 29, 2018

Codecov Report

Merging #130 into dev will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##              dev     #130   +/-   ##
=======================================
  Coverage   52.08%   52.08%           
=======================================
  Files          15       15           
  Lines        1342     1342           
  Branches      138      138           
=======================================
  Hits          699      699           
  Misses        628      628           
  Partials       15       15
Impacted Files Coverage Δ
pyhap/const.py 100% <100%> (ø) ⬆️

scripts/release Outdated
fi

# Upgrade setuptools to the latest version
python3 -m pip install --upgrade setuptools
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason to add this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the the metadata project_urls weren't redenered correctly and that the tag bdist_wheel (0.30.0) was included. That led me to belive that the setuptools version is probably outdated. Since this happend to me as well, I decided to add this.

If you want to, I'll remove it.
Just running pip install --upgrade setuptools would be enough as well.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may unexpectedly change the user env, I would prefer not to do it, if it is OK for you

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely! In that case it might be best to remove the wheel and twine installs down below as well.

@cdce8p
Copy link
Copy Markdown
Contributor Author

cdce8p commented May 29, 2018

I've removed all pip commands from the release script. Would be great if you could update setuptools nevertheless (only if it isn't the current version 39.2.0 already).

@ikalchev ikalchev merged commit d0ed617 into ikalchev:dev May 29, 2018
@ikalchev
Copy link
Copy Markdown
Owner

Unfortunately I will not be able to do another release for a few hours

@cdce8p cdce8p deleted the fix-setup_cfg branch May 29, 2018 15:20
@cdce8p
Copy link
Copy Markdown
Contributor Author

cdce8p commented May 29, 2018

No problem. It was my fault to begin with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants