Ensure events are not sent to the initiator client#215
Merged
ikalchev merged 1 commit intoikalchev:devfrom Jan 26, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #215 +/- ##
==========================================
+ Coverage 60.97% 61.57% +0.59%
==========================================
Files 16 16
Lines 1694 1697 +3
Branches 175 176 +1
==========================================
+ Hits 1033 1045 +12
+ Misses 622 612 -10
- Partials 39 40 +1
|
bdraco
force-pushed
the
avoid_send_events_to_sender_client_addr
branch
from
5d3d46d to
ad6c488
Compare
Clients that made the characteristic change are NOT supposed to get events about the characteristic change as it can cause an unexpected HTTP disconnect (connection reset by peer) which leads temporary unresponsive accessories and violates the HAP spec
bdraco
force-pushed
the
avoid_send_events_to_sender_client_addr
branch
from
ad6c488 to
1ac715d
Compare
Owner
Contributor
Author
|
@ikalchev The changes are still needed to make it compliant and avoid the disconnect when a message is sent when the client is not expecting one. |
Contributor
Author
|
The easiest way I found to replicate the disconnect is to rapidly turn a light on/off that is linked to home assistant as it will cause the event message to be sent to the server from the client while the client is writing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clients that made the characteristic change are NOT supposed to get
events
about the characteristic change as it can cause an unexpected HTTP
disconnect (connection
reset by peer) which leads temporary unresponsive accessories and
violates the HAP spec