Conversation
Codecov Report
@@ Coverage Diff @@
## dev #270 +/- ##
==========================================
- Coverage 64.50% 64.13% -0.38%
==========================================
Files 16 16
Lines 1761 1751 -10
Branches 189 191 +2
==========================================
- Hits 1136 1123 -13
- Misses 572 573 +1
- Partials 53 55 +2
|
I think we need a way to call |
|
Done, renamed |
|
Everything appears to work as expected in the linked PR (testing using the existing protected methods) |
pyhap/accessory_driver.py
Outdated
| self.topic_lock = threading.Lock() # for exclusive access to the topics | ||
| self.loader = loader or Loader() | ||
| self.aio_stop_event = asyncio.Event(loop=self.loop) | ||
| self.aio_stop_event = asyncio.Event() |
There was a problem hiding this comment.
This change is breaking Python 3.5 support. It's not necessary, just a drive by cleanup from when I saw warnings printed during tests. I will revert it.
bdraco
left a comment
There was a problem hiding this comment.
Verified working with home-assistant/core#37441
|
Verified this doesn't regress busy home example |
|
@ikalchev If this one looks good, could we get a new release? Thank you. |
|
Change is good, will release in the evening. Best, |
|
Thanks Ivan 👍 |
This improves loop handling for HAP-Python: