Skip to content

Ensure an error response is generated on exception#292

Merged
ikalchev merged 1 commit intoikalchev:devfrom
bdraco:ensure_connection_not_dropped_on_exception
Nov 28, 2020
Merged

Ensure an error response is generated on exception#292
ikalchev merged 1 commit intoikalchev:devfrom
bdraco:ensure_connection_not_dropped_on_exception

Conversation

@bdraco
Copy link
Copy Markdown
Contributor

@bdraco bdraco commented Nov 10, 2020

Improve spec compliance when an error occurs.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 10, 2020

Codecov Report

Merging #292 (16edd54) into dev (d3c576c) will increase coverage by 0.04%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##              dev     #292      +/-   ##
==========================================
+ Coverage   64.57%   64.62%   +0.04%     
==========================================
  Files          16       16              
  Lines        1787     1792       +5     
  Branches      196      198       +2     
==========================================
+ Hits         1154     1158       +4     
- Misses        576      577       +1     
  Partials       57       57              
Impacted Files Coverage Δ
pyhap/hap_server.py 39.18% <25.00%> (+0.40%) ⬆️

@ikalchev ikalchev merged commit a5c4933 into ikalchev:dev Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants