QR Code generation and dynamic pin/setup codes.#31
Closed
schinckel wants to merge 0 commit into
Closed
Conversation
Contributor
Author
|
I'm going to move the dynamic codes into a seperate PR. |
Contributor
|
Oh snap, I hadn't seen your fork. Sorry, I had just seen your last post was almost two weeks ago and no PR, so I decided to jump on it. Now I feel bad :( |
Contributor
Author
|
No biggie: I'm not sure if I'd actually pushed it or not, to be honest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not necessarily expecting this one to be merged in favour of #30, but just putting it here so we can compare the way I've done it compared to @jslay88.