Cleanup subscriptions on client disconnect#324
Merged
ikalchev merged 1 commit intoikalchev:devfrom Mar 3, 2021
Merged
Conversation
Contributor
bdraco
commented
Mar 3, 2021
bdraco
commented
- Solves a memory leak with topics
- Increase test coverage
Codecov Report
@@ Coverage Diff @@
## dev #324 +/- ##
==========================================
+ Coverage 84.07% 84.30% +0.22%
==========================================
Files 19 19
Lines 1865 1873 +8
Branches 216 219 +3
==========================================
+ Hits 1568 1579 +11
+ Misses 231 230 -1
+ Partials 66 64 -2
|
bdraco
force-pushed
the
cleanup_subscriptions_on_disconnect
branch
from
ad51aaa to
0097746
Compare
- Solves a memory leak with topics - Increase test coverage
bdraco
force-pushed
the
cleanup_subscriptions_on_disconnect
branch
from
0097746 to
c1002a9
Compare
Owner
|
Can't believe we catch that now. |
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.