Skip to content

Remove watcher from Windows (they don't exist)#343

Merged
ikalchev merged 2 commits intoikalchev:devfrom
jslay88:pr-issue-218
May 30, 2021
Merged

Remove watcher from Windows (they don't exist)#343
ikalchev merged 2 commits intoikalchev:devfrom
jslay88:pr-issue-218

Conversation

@jslay88
Copy link
Copy Markdown
Contributor

@jslay88 jslay88 commented May 10, 2021

Fixes #218

@codecov
Copy link
Copy Markdown

codecov bot commented May 10, 2021

Codecov Report

Merging #343 (62816de) into dev (ac90099) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev     #343   +/-   ##
=======================================
  Coverage   90.66%   90.66%           
=======================================
  Files          19       19           
  Lines        1897     1897           
  Branches      220      220           
=======================================
  Hits         1720     1720           
  Misses        133      133           
  Partials       44       44           
Impacted Files Coverage Δ
pyhap/accessory_driver.py 89.82% <0.00%> (ø)

@bdraco
Copy link
Copy Markdown
Contributor

bdraco commented May 10, 2021

I fixed the pylint issue in #342

@jslay88
Copy link
Copy Markdown
Contributor Author

jslay88 commented May 15, 2021

@bdraco @ikalchev Merged your commits in, but not sure how I am to add additional code coverage for a windows only line when the tests are running in a *nix environment. Probably just need Ivan to accept.

P.S. Hello, old friend @ikalchev !

@ikalchev
Copy link
Copy Markdown
Owner

Hey @jslay88, nice to see you again :)

@ikalchev ikalchev merged commit 55f3b5d into ikalchev:dev May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

module 'asyncio' has no attribute 'SafeChildWatcher'

3 participants