Skip to content

Handle additional cases of invalid hostnames#348

Merged
ikalchev merged 1 commit intoikalchev:devfrom
bdraco:valid_hostname
Jul 3, 2021
Merged

Handle additional cases of invalid hostnames#348
ikalchev merged 1 commit intoikalchev:devfrom
bdraco:valid_hostname

Conversation

@bdraco
Copy link
Copy Markdown
Contributor

@bdraco bdraco commented Jun 9, 2021

Some mDNS implementations were crashing when seeing the SRV records with a space which was translating to HASS\032Bridge\032._hap._tcp.local.

@bdraco bdraco force-pushed the valid_hostname branch 3 times, most recently from cbb5a4a to ebfb474 Compare June 9, 2021 09:29
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 9, 2021

Codecov Report

Merging #348 (e79075a) into dev (a2a5ce1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #348      +/-   ##
==========================================
+ Coverage   90.98%   91.01%   +0.02%     
==========================================
  Files          20       20              
  Lines        1931     1936       +5     
  Branches      225      225              
==========================================
+ Hits         1757     1762       +5     
  Misses        131      131              
  Partials       43       43              
Impacted Files Coverage Δ
pyhap/accessory_driver.py 90.46% <100.00%> (+0.13%) ⬆️

@bdraco bdraco force-pushed the valid_hostname branch 2 times, most recently from 3edf42b to 4e6add3 Compare June 9, 2021 09:50
@bdraco
Copy link
Copy Markdown
Contributor Author

bdraco commented Jun 17, 2021

Once I clean this up and add the missing coverage, need to do another PR to prep for the zeroconf namespace change from zeroconf.asyncio -> zeroconf.aio

We can do a condition import for the transition

try:
    from zeroconf.aio import AsyncZeroconf
except ImportError:
    from zeroconf.asyncio import AsyncZeroconf

@bdraco bdraco marked this pull request as ready for review June 18, 2021 00:49
@ikalchev ikalchev merged commit a52391e into ikalchev:dev Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants