Handle additional cases of invalid hostnames#348
Merged
ikalchev merged 1 commit intoikalchev:devfrom Jul 3, 2021
Merged
Conversation
cbb5a4a to
ebfb474
Compare
Codecov Report
@@ Coverage Diff @@
## dev #348 +/- ##
==========================================
+ Coverage 90.98% 91.01% +0.02%
==========================================
Files 20 20
Lines 1931 1936 +5
Branches 225 225
==========================================
+ Hits 1757 1762 +5
Misses 131 131
Partials 43 43
|
3edf42b to
4e6add3
Compare
Contributor
Author
|
Once I clean this up and add the missing coverage, need to do another PR to prep for the zeroconf namespace change from We can do a condition import for the transition try:
from zeroconf.aio import AsyncZeroconf
except ImportError:
from zeroconf.asyncio import AsyncZeroconf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some mDNS implementations were crashing when seeing the
SRVrecords with a space which was translating toHASS\032Bridge\032._hap._tcp.local.