Decrease snapshot timeout to avoid being disconnected#367
Merged
ikalchev merged 9 commits intoikalchev:devfrom Jul 29, 2021
Merged
Decrease snapshot timeout to avoid being disconnected#367ikalchev merged 9 commits intoikalchev:devfrom
ikalchev merged 9 commits intoikalchev:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #367 +/- ##
==========================================
- Coverage 91.01% 91.00% -0.01%
==========================================
Files 20 20
Lines 1937 1935 -2
Branches 224 224
==========================================
- Hits 1763 1761 -2
Misses 131 131
Partials 43 43
|
bdraco
force-pushed
the
decrease_timeout_avoid_disconnect
branch
from
d128e4d to
a48d1e2
Compare
bdraco
commented
Jul 27, 2021
bdraco
commented
Jul 27, 2021
…/HAP-python into decrease_timeout_avoid_disconnect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS will terminate the connection if it does not respond within
10 seconds, so we only allow 9 seconds to avoid this.
We no longer need to pause reading when taking a snapshot
as we have a working timeout