Allow passing the zeroconf server name when creating the AccessoryDriver#379
Merged
ikalchev merged 1 commit intoikalchev:devfrom Sep 2, 2021
Merged
Allow passing the zeroconf server name when creating the AccessoryDriver#379ikalchev merged 1 commit intoikalchev:devfrom
ikalchev merged 1 commit intoikalchev:devfrom
Conversation
- When there are multiple bridges running with the same address, each A record has to be kept fresh. By using the same server for all the bridges we avoid a case where the amount of broadcast traffic exceeds the limit and the bridges become unavailable
Codecov Report
@@ Coverage Diff @@
## dev #379 +/- ##
=======================================
Coverage 91.65% 91.65%
=======================================
Files 20 20
Lines 2084 2085 +1
Branches 257 257
=======================================
+ Hits 1910 1911 +1
Misses 132 132
Partials 42 42
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A record has to be kept fresh. By using the same server for all the bridges
we avoid a case where the amount of broadcast traffic exceeds the limit
and the bridges become unavailable