Handle invalid formats from clients#387
Merged
ikalchev merged 3 commits intoikalchev:devfrom Oct 6, 2021
Merged
Conversation
Some clients mix and match True for 1 and False for 0 when setting state. We now cleanup the values from the client to ensure internal state is always valid.
Codecov Report
@@ Coverage Diff @@
## dev #387 +/- ##
==========================================
+ Coverage 91.69% 91.73% +0.03%
==========================================
Files 20 20
Lines 2096 2104 +8
Branches 259 260 +1
==========================================
+ Hits 1922 1930 +8
Misses 132 132
Partials 42 42
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some clients (seen on iOS 15) mix and match True for 1 and False for 0
when setting state. We now cleanup the values from
the client to ensure internal state is always valid.