Switch to using ChaCha20Poly1305Reusable for encryption#413
Merged
ikalchev merged 4 commits intoikalchev:devfrom Jun 27, 2022
Merged
Switch to using ChaCha20Poly1305Reusable for encryption#413ikalchev merged 4 commits intoikalchev:devfrom
ikalchev merged 4 commits intoikalchev:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #413 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 20 20
Lines 2116 2116
Branches 287 287
=======================================
Hits 1942 1942
Misses 132 132
Partials 42 42
|
The ChaCha20Poly1305 that comes with cryptography recreates the ctx every time encrypt is called. Since we call encrypt in a loop, we can avoid this overhead by using ChaCha20Poly1305Reusable instead as we are doing everything in the same thread and not concerned about thread safety
This was referenced Jun 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ChaCha20Poly1305 that comes with cryptography recreates the
ctx every time encrypt is called. Since we call encrypt in
a loop, we can avoid this overhead by using ChaCha20Poly1305Reusable
instead as we are doing everything in the same thread.
This makes quite a difference for latency of large payloads such as camera images. It also seems to fix the Home app stalling out on iOS 16 betas when using them with Home Assistant's HomeKit integration.