Skip to content

Save raw client username bytes if they are missing on successful pair verify#458

Merged
ikalchev merged 2 commits intoikalchev:devfrom
bdraco:add_missing_bytes
Oct 5, 2023
Merged

Save raw client username bytes if they are missing on successful pair verify#458
ikalchev merged 2 commits intoikalchev:devfrom
bdraco:add_missing_bytes

Conversation

@bdraco
Copy link
Copy Markdown
Contributor

@bdraco bdraco commented Oct 5, 2023

We didn't used to save the raw bytes, but on the success case, iOS is going to send them to us again so we can save them if they are missing

Fixes #455

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 5, 2023

Codecov Report

Merging #458 (adafc3b) into dev (d9243b6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #458      +/-   ##
==========================================
+ Coverage   92.26%   92.27%   +0.01%     
==========================================
  Files          20       20              
  Lines        2198     2201       +3     
  Branches      278      279       +1     
==========================================
+ Hits         2028     2031       +3     
  Misses        124      124              
  Partials       46       46              
Files Coverage Δ
pyhap/hap_handler.py 86.28% <100.00%> (+0.10%) ⬆️

@bdraco
Copy link
Copy Markdown
Contributor Author

bdraco commented Oct 5, 2023

@ikalchev Since I was in the area, I fixed I would solve this problem as well as it should allow people who are missing the bytes and have the username saved in the wrong case to avoid re-pairing and it should just start working

@ikalchev ikalchev merged commit 50f731e into ikalchev:dev Oct 5, 2023
@bdraco bdraco deleted the add_missing_bytes branch October 6, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stopped working after upgrading to iOS 17

2 participants