Save raw client username bytes if they are missing on successful pair verify#458
Merged
ikalchev merged 2 commits intoikalchev:devfrom Oct 5, 2023
Merged
Save raw client username bytes if they are missing on successful pair verify#458ikalchev merged 2 commits intoikalchev:devfrom
ikalchev merged 2 commits intoikalchev:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #458 +/- ##
==========================================
+ Coverage 92.26% 92.27% +0.01%
==========================================
Files 20 20
Lines 2198 2201 +3
Branches 278 279 +1
==========================================
+ Hits 2028 2031 +3
Misses 124 124
Partials 46 46
|
Contributor
Author
|
@ikalchev Since I was in the area, I fixed I would solve this problem as well as it should allow people who are missing the bytes and have the username saved in the wrong case to avoid re-pairing and it should just start working |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We didn't used to save the raw bytes, but on the success case, iOS is going to send them to us again so we can save them if they are missing
Fixes #455