Char: override_properties#66
Merged
ikalchev merged 4 commits intoikalchev:devfrom Mar 25, 2018
cdce8p:char-template
Merged
Conversation
cdce8p
changed the title
cdce8p
changed the title
ikalchev
requested changes
Mar 24, 2018
Owner
ikalchev
left a comment
ikalchev
left a comment
There was a problem hiding this comment.
Can I ask you to add a test case for the new method in tests/test_characteristic.py?
| if properties: | ||
| self.properties.update(properties) | ||
|
|
||
| if valid_values: |
Owner
There was a problem hiding this comment.
I would add:
if valid_values:
if not "ValidValues" in self.properties:
raise ValueError(...)
else:
...
Owner
There was a problem hiding this comment.
Actually forget the above - I will check if you can set ValidValues on chars that don't have ValidValues defined and will get back to you or will submit a change myself.
ikalchev
approved these changes
Mar 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related discussion: #26
_create_hap_templatean merged this intoto_HAPoverride_propertiesfor charsself.has_valid_valuesand replaced it with runtime checks to prevent update errors