Reformat existing code using Google Style Guide

[npathai]

This issue is related to #221 . With this issue we will re-format existing implementation to confirm to Google Style guide.

[iluwatar]

https://github.com/google/styleguide/blob/gh-pages/eclipse-java-google-style.xml does not seem to work in Eclipse Mars.

[npathai]

@iluwatar I will take a look.

[iluwatar]

It has been suggested that we take into use Maven checkstyle plugin.

[npathai]

@iluwatar Yes good point. It will reduce PR review effort.

[iluwatar]

Checkstyle was added in a033c07

[iluwatar]

I updated the instructions at https://github.com/iluwatar/java-design-patterns/wiki/3.-Coding-conventions

[npathai]

@iluwatar The style guide worked for me in Eclipse Mars. To make sure this is how I imported it:
Java > Code Style > Formatter > Import

[iluwatar]

Are you importing this https://github.com/google/styleguide/blob/gh-pages/eclipse-java-google-style.xml?

I'm getting "Problems reading profiles from XML Attribute name "data-pjax-transient" associated with an element type "meta" must be followed by the ' = ' character."

[npathai]

Version: Mars (4.5)
Build no of eclipse: 20150621-1200
I get a version compatibility warning while importing but once I skip it, works fine.

[iluwatar]

Strange, I have the same version.

[Jahhein]

I was able to import these settings into intellij ultimate edition using an eclipse preferences plugin and use the reformat whole project feature. I have yet to make sure I meet all standards with what I have added. Is this still an issue to be resolved?