Skip to content

Conversation

@iluwatar
Copy link
Owner

@iluwatar iluwatar commented Jun 22, 2021

This pull request fixes grammar for all the Gang of Four patterns. Additionally, it partly resolves #590 by adding the missing explanations. 🥳 🎆

I'm also rewriting some examples so that their topic becomes more interesting. I hate boring code examples.

@iluwatar iluwatar requested a review from ohbus June 22, 2021 17:40
@ohbus ohbus self-assigned this Jun 24, 2021
Copy link
Contributor

@ohbus ohbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⭐

Thank you so much @iluwatar for the improvement! 🎉

@ohbus ohbus merged commit 04bf566 into master Jun 24, 2021
@ohbus ohbus added this to the 1.25.0 milestone Jun 24, 2021
RobbiNespu pushed a commit to RobbiNespu/java-design-patterns that referenced this pull request Mar 1, 2022
…ar#1791)

* Grammatical fixes to command pattern

* Update bridge pattern readme

* Fixes to builder pattern grammar

* Update chain of responsibility

* Improvements to the composite example

* Fixes to headings

* Minor updates to decorator pattern

* Update facade

* Update factory example

* Update factory method

* Update flyweight

* Interpreter explanation

* Update iterator readme

* Add explanation for mediator pattern

* Grammatical fixes to memento

* Grammar fixes for observer

* Update explanation for the prototype pattern

* Proxy pattern grammar fixes

* Update singleton

* Grammar fixes to state pattern

* Grammar fixes for strategy

* Grammar fixes, template method

* Grammar fixes for visitor

* Fix typo
@iluwatar iluwatar deleted the grammatical-fixes branch December 30, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explanation for design patterns

3 participants