Skip to content

Optimized NioReactor stop() (Reactor Pattern) #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 23, 2021
Merged

Optimized NioReactor stop() (Reactor Pattern) #1930

merged 2 commits into from
Dec 23, 2021

Conversation

yuhangbin
Copy link
Contributor

@yuhangbin yuhangbin commented Dec 14, 2021 •
edited
Loading

Optimize the closing mode of reactorMain(class: ExecutorService).
Ensure that reactorMain closes on time.

Please see the code.

Reference:

@iluwatar iluwatar self-assigned this Dec 19, 2021
@iluwatar
Copy link
Owner

@ohbus I would appreciate your consultation here. Do you have any idea why CircleCI test fails here?

iluwatar
iluwatar requested changes Dec 19, 2021
View reviewed changes
Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing due to Checkstyle issue

@ohbus
Copy link
Contributor

ohbus commented Dec 19, 2021

@ohbus I would appreciate your consultation here. Do you have any idea why CircleCI test fails here?

You're right about the check styles.

We have 3 builds checking the same code, all of them must not fail.

@iluwatar
Copy link
Owner

No Sonar PR analysis as this is not a pull request

@yuhangbin
Copy link
Contributor Author

I already use Google checkstyle.xml.

@yuhangbin
Copy link
Contributor Author

@ohbus @iluwatar Help me to run workflows. Thanks!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

77.8% 77.8% Coverage
0.0% 0.0% Duplication

@yuhangbin yuhangbin requested a review from iluwatar December 20, 2021 12:49
@iluwatar iluwatar added this to the 1.26.0 milestone Dec 23, 2021
@iluwatar iluwatar merged commit 6988319 into iluwatar:master Dec 23, 2021
@iluwatar
Copy link
Owner

Thank you for the valuable improvement!
@all-contributors please add @yuhangbin for code

@allcontributors allcontributors bot mentioned this pull request Dec 23, 2021
Merged
@allcontributors
Copy link
Contributor

@iluwatar

I've put up a pull request to add @yuhangbin! 🎉

RobbiNespu pushed a commit to RobbiNespu/java-design-patterns that referenced this pull request Mar 1, 2022
@yuhangbin @RobbiNespu
improvement: Optimized NioReactor stop() (Reactor Pattern) (iluwatar#…
bcbd49c 
…1930)

* Optimized NioReactor stop()

* Optimized ThreadPoolDispatcher stop()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iluwatar iluwatar iluwatar approved these changes

Assignees

@iluwatar iluwatar

Labels

status: under review

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

3 participants

@yuhangbin @iluwatar @ohbus