Upgrade JaCoCo plugin for JDK 17 compatibility (#2033) #2051
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve #2033 by bumping JaCoCo plugin to 0.8.8, as attempting to run
mvn clean installon the design modules under JDK 17 with the current version will result in thejava.lang.IllegalArgumentException: Unsupported class file major version 61error.For testing I've ran an overall
mvn clean installon the entire project under JDK 17 with source and target also set to 17 in thepom.xml, and only thenaked-objectspattern module produced an error (although there were warnings with other modules). It looks like the problem is rooted in an error running theDatanucleusenhancer insidedom(not much more error info) and errors insideintegtestswith using versions of theCucumberlibrary that's also too old from the Apache Isis dependency. I've tinkered with it a lot by updating dependencies and plugins insidenaked-objectsand still couldn't solve the errors, which is why I'm making this PR a draft.I see there have already been discussions with
naked-objectshaving some problems and being outdated from #1683 and #1669, and I'm happy to try rewrite thenaked-objectsto be more up-to-date and see if it can work with JDK 17 then. If it's crucial to havenaked-objectsbuild without errors under JDK 17 I'm happy to keep this PR in draft until the refactor is done.