Skip to content

Conversation

@HeVictor
Copy link
Contributor

@HeVictor HeVictor commented Oct 4, 2022

This PR aims to solve #2033 by bumping JaCoCo plugin to 0.8.8, as attempting to run mvn clean install on the design modules under JDK 17 with the current version will result in the java.lang.IllegalArgumentException: Unsupported class file major version 61 error.

For testing I've ran an overall mvn clean install on the entire project under JDK 17 with source and target also set to 17 in the pom.xml, and only the naked-objects pattern module produced an error (although there were warnings with other modules). It looks like the problem is rooted in an error running the Datanucleus enhancer inside dom (not much more error info) and errors inside integtests with using versions of the Cucumber library that's also too old from the Apache Isis dependency. I've tinkered with it a lot by updating dependencies and plugins inside naked-objects and still couldn't solve the errors, which is why I'm making this PR a draft.

I see there have already been discussions with naked-objects having some problems and being outdated from #1683 and #1669, and I'm happy to try rewrite the naked-objects to be more up-to-date and see if it can work with JDK 17 then. If it's crucial to have naked-objects build without errors under JDK 17 I'm happy to keep this PR in draft until the refactor is done.

@iluwatar iluwatar self-assigned this Oct 8, 2022
@iluwatar iluwatar added this to the 1.26.0 milestone Oct 8, 2022
@iluwatar
Copy link
Owner

iluwatar commented Oct 8, 2022

Thanks @HeVictor for looking into this. I think this change is safe to merge as it doesn't break anything in master.

@iluwatar iluwatar marked this pull request as ready for review October 8, 2022 16:40
@iluwatar iluwatar merged commit 20ce47b into iluwatar:master Oct 8, 2022
@iluwatar
Copy link
Owner

iluwatar commented Oct 8, 2022

@all-contributors please add @HeVictor for code

@allcontributors
Copy link
Contributor

@iluwatar

I've put up a pull request to add @HeVictor! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants