#2151 Feature/mvi pattern #2177

JanFidor · 2022-10-26T15:43:32Z

Add an MVI design pattern (includes pattern itself, tests, README.md and class diagram)

…emented)

iluwatar · 2022-11-05T08:35:47Z

The build is failing. Please investigate @JanFidor

…emented)

…e/mvi-pattern

JanFidor · 2022-11-07T16:01:42Z

@iluwatar It seems an independent module is causing issues (page-object). My build is failing even on the master branch after syncing the fork. The first error is caused by missing test dependencies, after adding them this line throws an error java: incompatible types: java.util.List<java.lang.Object> cannot be converted to java.util.List<com.gargoylesoftware.htmlunit.html.HtmlAnchor>
I'm not certain if I managed to break git on my part or if it's something else.

iluwatar · 2022-11-27T13:59:01Z

The error from the CI build is Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on project model-view-intent: You have 2 Checkstyle violations. @JanFidor

JanFidor · 2022-12-03T13:46:05Z

@iluwatar my bad for misinterpreting logs and sorry for the delay, university gave me plenty of work this week, but I'll get right on it now.

…e/mvi-pattern

JanFidor · 2022-12-10T19:50:41Z

@iluwatar fixed the violations, was a little closer to 60 after I run checkstyle locally, but it checks out now

…emented)

…e/mvi-pattern

model-view-intent/README.md

model-view-intent/src/main/java/com/iluwatar/model/view/intent/App.java

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorModel.java

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorView.java

model-view-intent/src/main/java/com/iluwatar/model/view/intent/actions/CalculatorAction.java

JanFidor · 2023-01-10T13:15:55Z

Hi, @iluwatar sorry for the long break, but the past couple of weeks have been pretty crazy on my end, but I'll be getting on it now

# Conflicts: # pom.xml

… had to change it back

sonarqubecloud · 2023-01-17T22:30:23Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
12 Code Smells

98.7% Coverage
0.0% Duplication

sonatype-lift · 2023-01-17T22:36:42Z

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorView.java

+ * and displays its updated {@link CalculatorModel}.
+ */
+@Slf4j
+@Data


ObjectToString: CalculatorViewModel is final and does not override Object.toString, so converting it to a string will print its identity (e.g. CalculatorViewModel@4488aabb) instead of useful information.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-17T22:36:44Z

...intent/src/main/java/com/iluwatar/model/view/intent/actions/SetVariableCalculatorAction.java

+/**
+ * SetVariable {@link CalculatorAction}.
+ */
+@Data


💬 7 similar findings have been found in this PR

Var: Non-constant variable missing @var annotation

Suggested change

@Data

@Var @Data

🔎 Expand here to view all instances of this finding

File Path Line Number

model-view-intent/src/main/java/com/iluwatar/model/view/intent/App.java 59

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorViewModel.java 27

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorModel.java 9

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorViewModel.java 70

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorView.java 19

model-view-intent/src/main/java/com/iluwatar/model/view/intent/App.java 54

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorView.java 71

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-17T22:36:46Z

...intent/src/main/java/com/iluwatar/model/view/intent/actions/SetVariableCalculatorAction.java

+/**
+ * SetVariable {@link CalculatorAction}.
+ */
+@Data


💬 3 similar findings have been found in this PR

Varifier: Consider using var here to avoid boilerplate.

Suggested change

@Data

var

🔎 Expand here to view all instances of this finding

File Path Line Number

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorView.java 19

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorViewModel.java 46

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorModel.java 9

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-17T22:36:49Z

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorModel.java

+/**
+ * Current state of calculator.
+ */
+@Data


💬 26 similar findings have been found in this PR

UnnecessarilyFullyQualified: This fully qualified name is unambiguous to the compiler if imported.

Suggested change

@Data

Override

🔎 Expand here to view all instances of this finding

File Path Line Number

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorView.java 18

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorView.java 19

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorModel.java 15

model-view-intent/src/main/java/com/iluwatar/model/view/intent/actions/SetVariableCalculatorAction.java 9

model-view-intent/src/main/java/com/iluwatar/model/view/intent/actions/SetVariableCalculatorAction.java 9

model-view-intent/src/main/java/com/iluwatar/model/view/intent/actions/SetVariableCalculatorAction.java 9

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorView.java 19

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorView.java 25

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorModel.java 9

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorModel.java 21

Showing 10 of 26 findings. Visit the Lift Web Console to see all.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-17T22:36:51Z

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorViewModel.java

+   *
+   * @param variable -> value of new calculator model variable.
+   */
+  private void setVariable(final Double variable) {


💬 3 similar findings have been found in this PR

UnnecessaryFinal: Since Java 8, it's been unnecessary to make local variables and parameters final for use in lambdas or anonymous classes. Marking them as final is weakly discouraged, as it adds a fair amount of noise for minimal benefit.

Suggested change

private void setVariable(final Double variable) {

private void setVariable( Double variable) {

🔎 Expand here to view all instances of this finding

File Path Line Number

model-view-intent/src/main/java/com/iluwatar/model/view/intent/App.java 54

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorViewModel.java 27

model-view-intent/src/main/java/com/iluwatar/model/view/intent/CalculatorView.java 71

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-17T22:36:54Z

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.¹

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/iluwatar/java-design-patterns/2177.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/iluwatar/java-design-patterns/2177.diff | git apply

Once you're satisfied commit and push your changes in your project.

You can preview the patch by opening the patch URL in the browser. ↩

JanFidor · 2023-01-18T15:00:36Z

@iluwatar I made the changes you suggested, I'm not certain what to do about sonatype-lift errors, especially when it comes to Lombok decorators and deleting the final keyword which would cause chackstyle errors (just like in the FSM PR)

iluwatar · 2023-01-21T09:43:12Z

Lift doesn't seem to handle Lombok annotations too well, so I think we can disregard them.

iluwatar · 2023-01-21T09:45:54Z

Looks good! Thank you for contributing this new pattern 🎉

@all-contributors please add @JanFidor for code

allcontributors · 2023-01-21T09:45:56Z

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@JanFidor already contributed before to code

JanFidor added 5 commits October 26, 2022 17:35

iluwatar#2151 add module and pom.xml

e6dc9fb

iluwatar#2151 add Calculator Actions

1d7c749

iluwatar#2151 add remaining mvi pattern classes (actions already impl…

e63bb63

…emented)

iluwatar#2151 add Main and unit tests

041f6e7

add README.md and class diagrams

b1aee16

iluwatar self-assigned this Nov 5, 2022

iluwatar added the status: under review label Nov 5, 2022

JanFidor added 6 commits November 6, 2022 15:09

iluwatar#2151 add module and pom.xml

5ff73e6

iluwatar#2151 add Calculator Actions

63b200a

iluwatar#2151 add remaining mvi pattern classes (actions already impl…

6cb029d

…emented)

iluwatar#2151 add Main and unit tests

c9abc01

add README.md and class diagrams

6d2ab68

Merge remote-tracking branch 'origin/feature/mvi-pattern' into featur…

113f653

…e/mvi-pattern

JanFidor added 2 commits November 10, 2022 14:00

Merge branch 'master' into feature/mvi-pattern

e23f1fe

Merge branch 'master' into feature/mvi-pattern

8ab3d93

JanFidor and others added 3 commits December 3, 2022 15:30

fixes for lint errors

4742d40

Merge remote-tracking branch 'origin/feature/mvi-pattern' into featur…

9297dfe

…e/mvi-pattern

Merge branch 'master' into feature/mvi-pattern

323b900

JanFidor added 7 commits December 12, 2022 22:39

iluwatar#2151 add module and pom.xml

c73b5e0

iluwatar#2151 add Calculator Actions

dccee21

iluwatar#2151 add remaining mvi pattern classes (actions already impl…

2b0964d

…emented)

iluwatar#2151 add Main and unit tests

04d1879

add README.md and class diagrams

5351eaf

fixes for lint errors

5d396b9

Merge remote-tracking branch 'origin/feature/mvi-pattern' into featur…

17c9482

…e/mvi-pattern

iluwatar requested changes Dec 13, 2022

View reviewed changes

JanFidor added 5 commits January 12, 2023 18:03

Merge branch 'master' into feature/mvi-pattern

d7d0439

# Conflicts: # pom.xml

Merge branch 'master' into feature/mvi-pattern

0ad9d04

use Lombok @DaTa decorator and decouple View from ViewModel

a90e506

add comments and documentation

487ff23

fix checkstyle, the smart switch syntax was breaking checkstyle, so I…

df0e08d

… had to change it back

sonatype-lift bot reviewed Jan 17, 2023

View reviewed changes

iluwatar approved these changes Jan 21, 2023

View reviewed changes

iluwatar merged commit fb86ca1 into iluwatar:master Jan 21, 2023

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

	private void setVariable(final Double variable) {
	private void setVariable( Double variable) {

Uh oh!

#2151 Feature/mvi pattern #2177

#2151 Feature/mvi pattern #2177

Uh oh!

Conversation

JanFidor commented Oct 26, 2022

Uh oh!

iluwatar commented Nov 5, 2022

Uh oh!

JanFidor commented Nov 7, 2022

Uh oh!

iluwatar commented Nov 27, 2022

Uh oh!

JanFidor commented Dec 3, 2022

Uh oh!

JanFidor commented Dec 10, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JanFidor commented Jan 10, 2023

Uh oh!

sonarqubecloud bot commented Jan 17, 2023

Uh oh!

sonatype-lift bot Jan 17, 2023

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 17, 2023

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 17, 2023

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 17, 2023

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 17, 2023

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot commented Jan 17, 2023

🛠 Lift Auto-fix

Footnotes

Uh oh!

JanFidor commented Jan 18, 2023

Uh oh!

iluwatar commented Jan 21, 2023

Uh oh!

iluwatar commented Jan 21, 2023

Uh oh!

allcontributors bot commented Jan 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants