Skip to content

Thread-Local Storage mechanism #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2023
Merged

Thread-Local Storage mechanism #2452

merged 1 commit into from
Jan 19, 2023

Conversation

Regyl
Copy link
Contributor

@Regyl Regyl commented Jan 14, 2023

Implements issue #2265

@Regyl Regyl closed this Jan 14, 2023
@Regyl Regyl reopened this Jan 14, 2023
@Regyl Regyl force-pushed the master branch 2 times, most recently from 7477665 to 6162b72 Compare January 15, 2023 01:40
@iluwatar
Copy link
Owner

@Regyl please note that there already is an implementation of the thread local storage pattern in tls subfolder. I'm not sure if you knew about that and wanted to replace the example?

@Regyl
Copy link
Contributor Author

Regyl commented Jan 15, 2023

@iluwatar sorry, didn't know TLS already implemented. In the older version almost nothing that my version wouldn't have had, so can I just delete it?
Or maybe combine into one folder, didn't find anything about this case in project's wiki.

@iluwatar
Copy link
Owner

@Regyl It's ok to replace the old example with this new one. Just delete the tls folder and remove the reference from the parent pom.xml.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Regyl
Copy link
Contributor Author

Regyl commented Jan 15, 2023

@iluwatar fixed it

@iluwatar iluwatar merged commit 196233d into iluwatar:master Jan 19, 2023
@iluwatar
Copy link
Owner

Looks good! Thank you for the contribution 🎉

@all-contributors please add @Regyl for code

@allcontributors allcontributors bot mentioned this pull request Jan 19, 2023
Merged
@allcontributors
Copy link
Contributor

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @Regyl! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iluwatar iluwatar iluwatar approved these changes

+1 more reviewer

@sonatype-lift sonatype-lift[bot] sonatype-lift[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Regyl @iluwatar