Skip to content

Conversation

@amit2103
Copy link
Contributor

Pull request for issue #179 (Leader Follower Pattern). Initial code ready for review.

@iluwatar
Copy link
Owner

iluwatar commented Nov 3, 2015

  • Put under review badge to the pull request
  • Does the example code implement the pattern correctly and follow good coding practices?
  • Does the example code have enough test coverage?
  • Is the example code commented well enough?
  • Is the example code following JavaDoc conventions?
  • Are the project coding conventions being followed?
  • Is the class diagram generated correctly?
  • Is the index.md implemented correctly so the pattern will show correctly on the web site?

Remarks:

  • Please catch up the changes from the master branch.
  • The application does not terminate automatically after running it.
  • The code comments especially in App.java could be more verbose. Please really try to explain how the pattern works.
  • There are some missing JavaDocs. I'll point out the places in the source code.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain a bit more!

@iluwatar
Copy link
Owner

iluwatar commented Nov 3, 2015

I've done my review. Please comment on this thread when the code is ready for another look.

@npathai
Copy link
Contributor

npathai commented Nov 17, 2015

I am a bit late to arrive at the scene. But I will review it as well.

@iluwatar
Copy link
Owner

I will work on this on another branch

@iluwatar iluwatar closed this Dec 20, 2015
@amit2103
Copy link
Contributor Author

@iluwatar Sorry for the delay...I have this implemented this..couldn't find the time to do some cleanup...I will make a new pull request within 2 days. If you dont recieve the pull request you can start working on this

@iluwatar
Copy link
Owner

@amit2103 Ok great, looking forward to the next pull request.

@amit2103
Copy link
Contributor Author

@iluwatar Thanks

@amit2103
Copy link
Contributor Author

Made the new pull request. Do check

pratigya0 pushed a commit to pratigya0/java-design-patterns that referenced this pull request Aug 3, 2023
Not only console solutions, but also Terraform and Pulumi.

In addition, this change fixes issues iluwatar#279 and iluwatar#280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants