Resolved issue #1323 Two-Step View pattern#3106
Resolved issue #1323 Two-Step View pattern#3106sharara6 wants to merge 3 commits intoiluwatar:masterfrom
Conversation
|
|
@iluwatar may you review this PR ? |
|
Dear @iluwatar may you check my PR? |
|
This is a gentle follow up. |
|
Thank you for your review. I am in the midst of final exams right now. May I work on it next week? |
Sure, no problem. Good luck with the exams 😄 |
PR SummaryThis PR implements the Two-Step View pattern, separating data preparation from presentation. It includes a new module ( Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (3)
Files Processed (12)
- microservices-idempotent-consumer/src/test/java/com/iluwatar/idempotentconsumer/AppTest.java (1 hunk)
- microservices-idempotent-consumer/src/test/java/com/iluwatar/idempotentconsumer/RequestStateMachineTests.java (1 hunk)
- pom.xml (1 hunk)
- two-step-view/README.md (1 hunk)
- two-step-view/pom.xml (1 hunk)
- two-step-view/src/main/java/com/iluwatar/App.java (1 hunk)
- two-step-view/src/main/java/com/iluwatar/Book.java (1 hunk)
- two-step-view/src/main/java/com/iluwatar/BookStore.java (1 hunk)
- two-step-view/src/main/java/com/iluwatar/DataPreparation.java (1 hunk)
- two-step-view/src/main/java/com/iluwatar/Presentation.java (1 hunk)
- two-step-view/src/test/java/com/iluwatar/BookStoreTest.java (1 hunk)
- update-header.sh (1 hunk)
Actionable Comments (0)
Skipped Comments (8)
-
microservices-idempotent-consumer/src/test/java/com/iluwatar/idempotentconsumer/AppTest.java [1-24]
best practice: "License header too verbose."
-
microservices-idempotent-consumer/src/test/java/com/iluwatar/idempotentconsumer/RequestStateMachineTests.java [1-24]
best practice: "License header too verbose."
-
two-step-view/src/main/java/com/iluwatar/App.java [1-27]
best practice: "License header too verbose."
-
two-step-view/src/main/java/com/iluwatar/Book.java [1-24]
best practice: "License header too verbose."
-
two-step-view/src/main/java/com/iluwatar/BookStore.java [1-24]
best practice: "License header too verbose."
-
two-step-view/src/main/java/com/iluwatar/DataPreparation.java [1-24]
best practice: "License header too verbose."
-
two-step-view/src/main/java/com/iluwatar/Presentation.java [1-24]
best practice: "License header too verbose."
-
two-step-view/src/test/java/com/iluwatar/BookStoreTest.java [1-24]
best practice: "License header too verbose."
|
iluwatar
left a comment
There was a problem hiding this comment.
Additionally, please resolve the conflicts.
| @@ -0,0 +1,156 @@ | |||
| # Two-Step View | |||
There was a problem hiding this comment.
Add front-matter as instructed in https://github.com/iluwatar/java-design-patterns/wiki/21.-New-Pattern-Template
| --- | ||
|
|
||
| ## Programmatic Example of Two-Step View Pattern in Java | ||
|
|
There was a problem hiding this comment.
Add short programmatic example here. See the other patterns for examples of how to do this.
|
Closed due to inactivity. Thank you for the contribution. |







created a two-step view design pattern for more details check the read-me file
close issue #1323