Closed
Conversation
Implemented the Layer Supertype Pattern in Service Layer, updated README file and PUML class diagram to reflect the new changes.
Remove unused imports from test files
Added exception testing for DaoBaseImpl methods
|
iluwatar
requested changes
Jan 11, 2025
Owner
iluwatar
left a comment
iluwatar
left a comment
There was a problem hiding this comment.
Looks ok in general, but
- Can we create its own pattern example about this? I.e. not mix it with Service layer.
- Strip out all the unnecessary complexity of the service layer to make the example as clear as possible
|
This PR is stale because it has been open 60 days with no activity. |
Owner
|
Closed due to inactivity. Thank you for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the Layer Supertype Pattern in Service Layer, updated README file and PUML class diagram to reflect the new changes.
closes #1302