server-side-page-fragment-composition#3146
Closed
SARAELGYAR wants to merge 1 commit intoiluwatar:masterfrom
Closed
server-side-page-fragment-composition#3146SARAELGYAR wants to merge 1 commit intoiluwatar:masterfrom
SARAELGYAR wants to merge 1 commit intoiluwatar:masterfrom
Conversation
|
iluwatar
requested changes
Jan 6, 2025
| @@ -0,0 +1,31 @@ | |||
| # Read Me First | |||
Owner
There was a problem hiding this comment.
Please study the contribution instructions: https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute
Every pattern has a README.md file with a very specific format.
Comment on lines
+5
to
+10
| <parent> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-parent</artifactId> | ||
| <version>3.4.0</version> | ||
| <relativePath/> <!-- lookup parent from repository --> | ||
| </parent> |
Owner
There was a problem hiding this comment.
Each submodule should refer to top level parent pom.xml which is included in this project
Comment on lines
+9
to
+11
| @Test | ||
| void contextLoads() { | ||
| } |
Owner
There was a problem hiding this comment.
I don't think this single test is sufficient
|
This PR is stale because it has been open 60 days with no activity. |
Owner
|
Closed due to inactivity. Thank you for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?