Adds remote-procedure-call via gRPC#3189
Closed
CoderSleek wants to merge 1 commit intoiluwatar:masterfrom
Closed
Conversation
PR SummaryThis PR implements remote procedure calls using gRPC in Java. It introduces two microservices, Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 390358d: remote-procedure-call
Files Processed (30)
- pom.xml (1 hunk)
- remote-procedure-call/README.md (1 hunk)
- remote-procedure-call/cart-service/etc/cart-service.urm.png (0 hunks)
- remote-procedure-call/cart-service/etc/cart-service.urm.puml (1 hunk)
- remote-procedure-call/cart-service/pom.xml (1 hunk)
- remote-procedure-call/cart-service/src/main/java/com/iluwatar/rpc/cart/Main.java (1 hunk)
- remote-procedure-call/cart-service/src/main/java/com/iluwatar/rpc/cart/model/ProductInCart.java (1 hunk)
- remote-procedure-call/cart-service/src/main/java/com/iluwatar/rpc/cart/service/CartService.java (1 hunk)
- remote-procedure-call/cart-service/src/main/java/com/iluwatar/rpc/cart/service/CartServiceImpl.java (1 hunk)
- remote-procedure-call/cart-service/src/main/resources/logback.xml (1 hunk)
- remote-procedure-call/cart-service/src/test/java/com/iluwatar/rpc/cart/service/CartServiceImplIntegrationTest.java (1 hunk)
- remote-procedure-call/cart-service/src/test/java/com/iluwatar/rpc/cart/service/CartServiceImplTest.java (1 hunk)
- remote-procedure-call/cart-service/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker (1 hunk)
- remote-procedure-call/etc/remote-procedure-call.urm.puml (1 hunk)
- remote-procedure-call/pom.xml (1 hunk)
- remote-procedure-call/product-service/etc/product-service.urm.png (0 hunks)
- remote-procedure-call/product-service/etc/product-service.urm.puml (1 hunk)
- remote-procedure-call/product-service/pom.xml (1 hunk)
- remote-procedure-call/product-service/src/main/java/com/iluwatar/rpc/product/Main.java (1 hunk)
- remote-procedure-call/product-service/src/main/java/com/iluwatar/rpc/product/mocks/ProductMocks.java (1 hunk)
- remote-procedure-call/product-service/src/main/java/com/iluwatar/rpc/product/model/Product.java (1 hunk)
- remote-procedure-call/product-service/src/main/java/com/iluwatar/rpc/product/service/ProductService.java (1 hunk)
- remote-procedure-call/product-service/src/main/java/com/iluwatar/rpc/product/service/ProductServiceGrpcImpl.java (1 hunk)
- remote-procedure-call/product-service/src/main/java/com/iluwatar/rpc/product/service/ProductServiceImpl.java (1 hunk)
- remote-procedure-call/product-service/src/main/resources/logback.xml (1 hunk)
- remote-procedure-call/product-service/src/test/java/com/iluwatar/rpc/product/service/ProductServiceGrpcImplTest.java (1 hunk)
- remote-procedure-call/product-service/src/test/java/com/iluwatar/rpc/product/service/ProductServiceImplTest.java (1 hunk)
- remote-procedure-call/product-service/src/test/java/com/iluwatar/rpc/product/service/ProductServiceIntegrationTest.java (1 hunk)
- remote-procedure-call/product-service/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker (1 hunk)
- remote-procedure-call/proto/shopping.proto (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
|
iluwatar
requested changes
Feb 22, 2025
| @@ -0,0 +1,147 @@ | |||
| --- | |||
Owner
There was a problem hiding this comment.
README.md needs to follow the specified format. See https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute
Author
There was a problem hiding this comment.
@iluwatar is it fine to attach a link from GeeksForGeeks or any reliable website for the architecture diagram?
Owner
There was a problem hiding this comment.
I would prefer own production. You can also leave it out for now. I've used https://whimsical.com/ myself to describe the architectural patterns.
Comment on lines
+36
to
+42
| /** | ||
| * Main class for the cart service. | ||
| * Initializes the shopping channel and the cart service. | ||
| * | ||
| * @author CoderSleek | ||
| * @version 1.0 | ||
| */ |
Owner
There was a problem hiding this comment.
Here, above the class, please explain the pattern briefly and describe how the example implements it
Comment on lines
+54
to
+72
| ManagedChannel productChannel = ManagedChannelBuilder | ||
| .forAddress(HOST, SERVER_PORT) | ||
| .usePlaintext() | ||
| .enableRetry() | ||
| .keepAliveTime(10, TimeUnit.SECONDS) | ||
| .build(); | ||
|
|
||
| ShoppingServiceBlockingStub blockingStub = ShoppingServiceGrpc.newBlockingStub(productChannel); | ||
| log.info("cart-service started"); | ||
|
|
||
| var cartService = new CartServiceImpl(blockingStub); | ||
| cartService.getAllProducts(); | ||
|
|
||
| var productInCart = cartService.getRandomProductFromCart(); | ||
| productInCart.setQuantityToReduce(10); | ||
|
|
||
| cartService.reduceCartQuantityFromProduct(productInCart); | ||
| productChannel.shutdown(); | ||
| log.info("cart-service execution successful, shutting down"); |
Owner
There was a problem hiding this comment.
Add comments. Remember, this is material for studying the design pattern.
Owner
|
Closed due to inactivity. Thank you for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2680