Override annotation added

[slawiko]

I think this is a typo

[coveralls]

Coverage increased (+0.2%) to 90.955% when pulling 0c56d80 on slawiko:patch-1 into 9074a9c on iluwatar:master.

[iluwatar]

In my opinion it is good to have the @Override annotation when implementing interface methods. This way we can utilize compiler checks to verify that the implementing method signature really matches the interface and is not a new method. We could enforce this with Checkstyle i.e. Checkstyle would give an error if interface method implementation would not specify @Override. @slawiko @npathai what do you think?

[slawiko]

@iluwatar I thought it was already in your Checkstyle. Howbeit we MUST add it in checkstyle :)

[iluwatar]

@slawiko it is not there yet, otherwise the build would not work. Maybe it is this one: http://checkstyle.sourceforge.net/config_annotation.html#MissingOverride Could you try adding it and see what happens?

[slawiko]

@iluwatar yes of course, but not right now.

[iluwatar]

No problem, just let us know then.

[slawiko]

@iluwatar I read some information about Checkstyle and now I can do something. As I understood <module name="MissingOverride"/> works only if code contains JavaDoc tag {@inheritDoc}. But if I add this tag code inspection with still passes checkstyle: I use Checkstyle for the first time, so I can be wrong. By the way, I tried without JavaDoc tag {@inheritDoc}, but result was identical. What do I do wrong?

[iluwatar]

Looks like MissingOverride is not what we want. I'm not sure if Checkstyle has exactly what we need.

[iluwatar]

My suspicion is verified in http://checkstyle.sourceforge.net/google_style.html

"6.1 @OverRide: always used" - "That validation could not be checked by Checkstyle. It's need to take a look as parent class. But Checkstyle have no way open or look at another Class file. "

[iluwatar]

Thanks @slawiko for the improvement!

[slawiko]

@iluwatar you're welcome!