#587 sonarqube bugs #599
#587 sonarqube bugs #599
Conversation
| * | ||
| */ | ||
| public class Client extends JFrame { | ||
| public class Client extends JFrame { // NOSONAR |
There was a problem hiding this comment.
Sonarqube reported "This class has 6 parents which is greater than 5 authorized"
Here is the inheritance hierarchy.
FileSelectorJFrame -> JFrame -> Frame -> Window -> Container -> Component implements ImageObserver, MenuContainer, Serializable
I believe, it is most common to subclass JFrame for creating window.
Alternate design by following "Use composition over inheritance". I thought it would make more changes and may spoil the brevity of explaining the design pattern.
Please let me know if you want me to think about the alternate design
| private static final long serialVersionUID = 1L; | ||
|
|
||
| private FilterManager filterManager; | ||
| private transient FilterManager filterManager; |
There was a problem hiding this comment.
Making it transient doesn't introduce any problems?
There was a problem hiding this comment.
It did not introduce any problem.
Alternate solution would be making FilterManager and its parents as Serializable. In this example, we are not transferring Client instance or planning to serialize, So I decided to make it transient to keep it simple.
Let me know if you prefer marking all classes as Serializable as long as it does not have any non-serialized attributes.
| * | ||
| */ | ||
| public class Target extends JFrame { | ||
| public class Target extends JFrame { //NOSONAR |
|
@mookkiah thanks for the explanations. It looks good to be merged. Well done 👍 |
3 participants
No description provided.