#587 SonarQube reports bugs #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mookkiah I'm not sure which SonarQube issue this PR fixes? |
|
Thanks @mookkiah the fix has been merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking FileLoader (Model) as Serializable, because model is an interface to provide data and it can provide caching behaviour. Presenter should be able to restore the model in any event.
Marking FileSelectorView as Serializable as I think view is made up of some static structure and Serializable data (from model).
Presenter is an middle-man who manages View and Model. Both View and Model will be given to Presenter by the application. It will not make any harm to make presenter as Serializable. It will be useful serialize model and view as it is tied to one another.
Or, we could set //NOSONAR and let the consumer application framework to decide whether to mark as Serializable or not based on their design.
References:
https://en.wikipedia.org/wiki/Model%E2%80%93view%E2%80%93presenter
https://medium.com/@cervonefrancesco/model-view-presenter-android-guidelines-94970b430ddf