Skip to content

Conversation

@0xA537FD
Copy link

No description provided.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@npathai
Copy link
Contributor

npathai commented Sep 27, 2017

@Peter-Morawski A unit test case of Balking pattern is causing the build to fail. Can you run build locally to verify?

@0xA537FD
Copy link
Author

@npathai I ran all test cases successfully and could even build and run the balking pattern without any problems.

image

image

image

@npathai
Copy link
Contributor

npathai commented Sep 29, 2017

@iluwatar Any idea what might be causing this? Diff shows no change in tests, but still build has failing tests for Balking pattern

@iluwatar
Copy link
Owner

@npathai could not reproduce. The fail is not related to this pull request anyway so I think this can be accepted. Please raise a new issue about the Balking pattern test failure so we can investigate further.

@npathai npathai merged commit b2dd175 into iluwatar:master Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants