Resolves #643, test cases failed due to global state in CallsCount #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allsCount. Because AppTest was executed before B2BServiceTest, it scheduled 1 sec timer using ThrottleTimerImpl class. While resetting it used that global CallCount class reset() method, which reset all counters. So that causes thread safety issue because of unintended sharing of application state between test cases, which is not a good practice.
Owner
|
The proposed solution looks good |
Contributor
Author
|
@iluwatar Updated the class diagram. Ready to merge! |
iluwatar
approved these changes
Oct 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #643
Root Cause
Test cases failed due to presence of global state in
CallsCount. BecauseAppTestwas executed beforeB2BServiceTest, it scheduled 1 sec timer usingThrottleTimerImplclass. While resetting it used that globalCallCount.reset()method, which reset all counters. So that causes thread safety issue because of unintended sharing of application state between test cases, which is not a good practice.Solution
Solution was not to have global state using
staticmap. Rather global state should be maintained using single object and passing that as dependency wherever needed.Todos