508 : sonar qube critical issue fixes #852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define a constant instead of duplicating this literal "user_accounts" 4 times. Define a constant instead of duplicating this literal "userID" 5 times Define a constant instead of duplicating this literal "additionalInfo" 4 times. Define a constant instead of duplicating this literal "userName" 4 times.
Define a constant instead of duplicating this literal "user_accounts" 4 times.
Define a constant instead of duplicating this literal "eEvans" 4 times Define a constant instead of duplicating this literal "jBloch" 6 times Define a constant instead of duplicating this literal "mFowler" 3 times
Define a constant instead of duplicating this literal "username" 3 times.
Define a constant instead of duplicating this literal "customerDao.getAllCustomers(): " 4 times.
Define a constant instead of duplicating this literal "App.main(), student : " 4 times.
Define a constant instead of duplicating this literal "{} hits {}. {} is damaged!" 3 times.
Define a constant instead of duplicating this literal "{} hits {}." 4 times.
|
@iluwatar Can you assign someone to review this and merge |
iluwatar
approved these changes
Jul 28, 2019
|
Thanks @kanwarpreet25 👍 |
hoangnam2261
pushed a commit
to hoangnam2261/java-design-patterns
that referenced
this pull request
Jul 30, 2019
* 508 : sonar qube critical issue fixes
* 508 : Sunar Qube Fixes
Define a constant instead of duplicating this literal "user_accounts" 4 times.
Define a constant instead of duplicating this literal "userID" 5 times
Define a constant instead of duplicating this literal "additionalInfo" 4 times.
Define a constant instead of duplicating this literal "userName" 4 times.
* 508 : Sunar Qube Fixes
Define a constant instead of duplicating this literal "user_accounts" 4 times.
* 508 : Sonar Qube Fixes
Define a constant instead of duplicating this literal "eEvans" 4 times
Define a constant instead of duplicating this literal "jBloch" 6 times
Define a constant instead of duplicating this literal "mFowler" 3 times
* 508 : Sonar Qube FIxes
Define a constant instead of duplicating this literal "username" 3 times.
* 508: sonar qube issue fixes
Define a constant instead of duplicating this literal "customerDao.getAllCustomers(): " 4 times.
* 508 : sonar qube issue fixes
Define a constant instead of duplicating this literal "App.main(), student : " 4 times.
* 508 : sonar Qube issue fixes
Define a constant instead of duplicating this literal "{} hits {}. {} is damaged!" 3 times.
Define a constant instead of duplicating this literal "{} hits {}." 4 times.
* 508 : Define a constant instead of duplicating this literal "{} hits {}." 4 times.
* 508 : checkstyle fixes
* 508: checkstyle fixes
* 508: checkstyle fixes
* 508: checkstyle fixes
* 508: checkstyle fixes
* 508: checkstyle fixes
* 508: cqrs checkstyle fixes
mookkiah
reviewed
Sep 27, 2020
|
|
||
| @Override | ||
| public void collisionResolve(SpaceStationIss iss) { | ||
| LOGGER.info("{} hits {}. {} is damaged!", iss.getClass().getSimpleName(), |
There was a problem hiding this comment.
I noticed this change resulted into more arguments than the placeholder. This resulting log statement as below
04:54:48.252 [main] INFO com.iluwatar.doubledispatch.SpaceStationMir - {} is damaged! {} is set on fire! hits FlamingAsteroid.
04:54:48.278 [main] INFO com.iluwatar.doubledispatch.SpaceStationMir - {} is damaged! {} is set on fire! hits FlamingAsteroid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request title
Pull request description