Skip to content

fix possible double call to "beforeInitEvent.done()" #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix possible double call to "beforeInitEvent.done()" #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix possible double call to "beforeInitEvent.done()" 
now surrounding beforeInitEvent notification with lockInit/releaseInit:
 - done() will be called as before (but with removed duplicate logic)
 - done() will not risk of being called twice (this happened when a beforeInitEvent trigger was locking and releasing the event fast)
  • Loading branch information
@twitwi
twitwi committed Apr 1, 2014
commit 581a48bc1f08a9d4b7c39651cf980603735a5f6e
5 changes: 2 additions & 3 deletions core/deck.core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,10 +411,9 @@ that use the API provided by core.
$document.trigger(events.initialize);
};

beforeInitEvent.lockInit();
$document.trigger(beforeInitEvent);
if (!beforeInitEvent.locks) {
beforeInitEvent.done();
}
beforeInitEvent.releaseInit();
window.setTimeout(function() {
if (beforeInitEvent.locks) {
if (window.console) {
Expand Down