Add AccessControl, Pausable to GemGame contract #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drinkcoffee
previously approved these changes
Apr 12, 2024
pano-skylakis
changed the title
keithbro-imx
previously approved these changes
Apr 12, 2024
| @@ -1,21 +1,63 @@ | |||
| // Copyright (c) Immutable Pty Ltd 2018 - 2024 | |||
| // SPDX-License-Identifier: Apache 2 | |||
| // solhint-disable not-rely-on-time | |||
There was a problem hiding this comment.
we do, specifically for this line https://github.com/immutable/contracts/pull/200/files#diff-fe9f97ca149602fd40e7caaba1458383ddde181249e482aaa94bea8bbc412803R61
It's for any code using block.timestamp
keithbro-imx
approved these changes
Apr 12, 2024
drinkcoffee
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds access control and pausable functionality to the GemGame contract.
This will allow pausing of the contract if we find that it is being abused.