Skip to content

ERC721 Mint By Quantity V2 (second attempt) #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Mar 3, 2025
Merged

ERC721 Mint By Quantity V2 (second attempt) #265

merged 40 commits into from
Mar 3, 2025

Conversation

drinkcoffee
Copy link
Contributor

Changes:

  • Made a copy of ImmutableERC721 contract and dependant contracts and called them V2 contracts. The only major differences are in the ERC721PSIV2 and ERC721PSIBurnable contracts.
  • Added interfaces for ERC721 contracts, so common features for contracts can sit behind an interface. This has allowed for the same tests to be used across implementations.
  • Migrated ERC721 HardHat tests to Forge.
  • Added many additional tests to improve test coverage.
  • Added perfTest directory, that includes test that check the gas efficiency of ERC721 contract implementations.
  • Added fuzz testing

@drinkcoffee
Initial forge tests
33c4d65
@drinkcoffee
Added initial test
35ba4ac
@drinkcoffee
Create initial performance tests
84bad32
@drinkcoffee
Mint at 15K per block to max out the blocks
5c9f3a9
@drinkcoffee
Added more tests
80bce5d
@drinkcoffee
Add more tests
0f14037
@drinkcoffee
Revise import order
bf0837f
@drinkcoffee
Initial compiling version of PsiV2
f70f480
@drinkcoffee
Resolved issues with PsiV2
011ccb4
@drinkcoffee
Fixed issue with determing existance of an NFT
47c0079
@drinkcoffee
Improve documentation. Prefill by 160K
f72216a
@drinkcoffee
Migrate ERC721 tests to forge
dedbc6b
@drinkcoffee
Improve ERC 721 test coverage
5861530
@drinkcoffee
Added more tests
e48d49c
@drinkcoffee
Add more tests and remove dead code
a74fa1b
@drinkcoffee
Added documentation for ERC721PsiV2
f5c0f86
@drinkcoffee
Added more tests
3f56c1b
@drinkcoffee
Change solidity version
540e221
@drinkcoffee
Merge branch 'main' into peter-solidity-version
c53427a
@drinkcoffee
Merge branch 'peter-solidity-version' into peter-erc721-perf
bea8ee7
@drinkcoffee
Add more tests
ce033e3
@drinkcoffee
Added transferFrom tests
36c41e7
@drinkcoffee
Added more tests
59b6c1a
@drinkcoffee
Rename files
6912c29
@drinkcoffee
Merge branch 'main' into peter-erc721-perf
4045cac
@drinkcoffee
Add documentation for ERC 721 contracts
0f31fa1
@drinkcoffee
Fix prettier issues
2be5039
@drinkcoffee
Fix solidity version and remove dead code
c5f3ec5
@drinkcoffee
Add solhint support for PsiV2
0cc0e1b
@drinkcoffee
Fixed last Slither warning
e7e359c
@drinkcoffee drinkcoffee requested review from a team February 25, 2025 01:10
@drinkcoffee drinkcoffee mentioned this pull request Feb 25, 2025
Closed
@drinkcoffee
Copy link
Contributor Author

This PR builds off #263, integrating the work from the security team, and resolving build issues.

rytimx
rytimx approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@rytimx rytimx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for putting this together.

@drinkcoffee drinkcoffee merged commit d7162ec into main Mar 3, 2025
8 checks passed
@drinkcoffee drinkcoffee deleted the peter-erc721-perf2 branch May 15, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rytimx rytimx rytimx approved these changes

@ermyas ermyas Awaiting requested review from ermyas

@wcgcyx wcgcyx Awaiting requested review from wcgcyx

+1 more reviewer

@ipekt ipekt ipekt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drinkcoffee @ipekt @rytimx