Conversation
bwplotka
changed the title
Member
Author
|
Upstream PR for TSDB fork I added: prometheus-junkyard/tsdb#492 |
bwplotka
force-pushed
the
prometheus-upgrade
branch
2 times, most recently
from
9c7ef2e to
8d02d61
Compare
bwplotka
changed the title
bwplotka
force-pushed
the
prometheus-upgrade
branch
6 times, most recently
from
0b0e772 to
3fc01a5
Compare
Member
Author
|
Upstream required change merged. prometheus-junkyard/tsdb#492 (review) Now we need to fork prometheus only until this change will be in prometheus TSDB pinned version. |
bwplotka
force-pushed
the
prometheus-upgrade
branch
4 times, most recently
from
efd58fb to
d87cf3e
Compare
This was referenced Jan 22, 2019
bwplotka
force-pushed
the
prometheus-upgrade
branch
from
d87cf3e to
5c1d5c9
Compare
Member
Author
|
@FUSAKLA PTAL (: |
bwplotka
force-pushed
the
posting-fetcher
branch
from
4d4eeac to
9e12e0b
Compare
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things. Bigger packages we use and changes I found manually: * prometheus/prometheus/discovery/file * [ENHANCEMENT] Discovery: Improve performance of previously slow updates of changes of targets. #4526 ?? cc @ivan-valkov * [BUGFIX] Wait for service discovery to stop before exiting #4508 ?? * prometheus/prometheus/promql: * [BUGFIX] PromQL: Fix a goroutine leak in the lexer/parser. #4858 * [BUGFIX] Change max/min over_time to handle NaNs properly. #438 * [BUGFIX] Check label name for `count_values` PromQL function. #4585 * [BUGFIX] Ensure that vectors and matrices do not contain identical label-sets. #4589 * [ENHANCEMENT] Optimize PromQL aggregations #4248 * [BUGFIX] Only add LookbackDelta to vector selectors #4399 * [BUGFIX] Reduce floating point errors in stddev and related functions #4533 * prometheus/prometheus/rules: * New metrics exposed! (prometheus evaluation!) * [ENHANCEMENT] Rules: Error out at load time for invalid templates, rather than at evaluation time. #4537 * prometheus/tsdb/index: Index reader optimizations. There are things/fixes we may reuse in next PRs (TODO create gh issues for those): * api changes (warnings support on Prometheus UI and Query API) * UI fixes: * [ENHANCEMENT] Web UI: Support console queries at specific times. #4764 * [ENHANCEMENT] Web UI: Avoid browser spell-checking in expression field. #472 * Use notifier package once prometheus/prometheus#5025 is merged. * Ruler UI fixes: * [ENHANCEMENT] Show rule evaluation errors in UI #4457 Follopw up issues we can fix in further PRs: * QueryAPI has now api/v1/labels that Thanos does not yet support. Created issue with details: #702 * #703 Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
prometheus-upgrade
branch
from
5c1d5c9 to
07739f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does not add anything, however by upgrading Prometheus from 2.3.2 to master tip and same for TSDB it may affects few things.
Bigger packages we use and changes I found manually:
prometheus/prometheus/discovery/file
ThanosSidecarUnhealthytoThanosSidecarNoConnectionToStartedPrometheus; RemoveThanosSidecarPrometheusDownalert; Remove unusedthanos_sidecar_last_heartbeat_success_time_secondsmetrics #4508 ??prometheus/prometheus/promql:
count_valuesPromQL function. match support for labels api in query frontend #4585prometheus/prometheus/rules:
prometheus/tsdb/index: Index reader optimizations.
There are things/fixes we may reuse in next PRs (TODO create gh issues for those):
Follopw up issues we can fix in further PRs:
Signed-off-by: Bartek Plotka bwplotka@gmail.com