docs-0.21: Add mdox link checking and formatting#4537
Merged
bwplotka merged 1 commit intothanos-io:release-0.21from Aug 10, 2021
Merged
docs-0.21: Add mdox link checking and formatting#4537bwplotka merged 1 commit intothanos-io:release-0.21from
bwplotka merged 1 commit intothanos-io:release-0.21from
Conversation
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
bwplotka
approved these changes
Aug 10, 2021
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Let's go!
Test failures are worrying but those are because somehow prometheus bingo .mod file does not have the right replace statements (they might work before but due to how the go module works, Go mod picked newer dep that now is incompatible for this Prom version). I would say, this breaks Prom installation on this branch even without @saswatamcode change, so not a blocker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds mdox to
release-0.21branch. Related to #4357.