Skip to content

Conversation

@qinling0210
Copy link
Contributor

@qinling0210 qinling0210 commented Dec 10, 2025

What problem does this PR solve?

Put minio-cpp to vcpkg

  1. Put minio-cpp in dependencies part of vcpkg.json, minio-cpp depends on curlpp and curl, vcpkg will also download curpp and curl.
  2. Remove minio-cpp, curlpp, curl from third_party directory
  3. Change CMakeLists.txt

Patch minio-cpp and curlpp in vcpkg using fix in #2027

Type of change

  • Other (please describe): vcpkg.json, CMakeLists.txt

@qinling0210 qinling0210 self-assigned this Dec 10, 2025
@qinling0210 qinling0210 added the ci PR can be test label Dec 10, 2025
@qinling0210 qinling0210 marked this pull request as ready for review December 10, 2025 07:17
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.98%. Comparing base (72cd528) to head (3ac6a90).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3174      +/-   ##
==========================================
+ Coverage   47.39%   49.98%   +2.59%     
==========================================
  Files         725      725              
  Lines      152052   152052              
  Branches    27707    27707              
==========================================
+ Hits        72065    76010    +3945     
+ Misses      70409    66030    -4379     
- Partials     9578    10012     +434     
Flag Coverage Δ
debug http test 27.83% <ø> (-0.01%) ⬇️
debug parallel test 17.67% <ø> (+0.03%) ⬆️
debug pysdk test 29.77% <ø> (+29.77%) ⬆️
debug sqllogical test 31.74% <ø> (-0.18%) ⬇️
debug unit test 38.57% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@qinling0210 qinling0210 added the slow-test To trigger slow test label Dec 10, 2025
@qinling0210 qinling0210 marked this pull request as draft December 10, 2025 12:30
@qinling0210 qinling0210 marked this pull request as ready for review December 10, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci PR can be test slow-test To trigger slow test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant