Skip to content

feat: support configuring multiple hosts when creating a cluster #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
silenceqi merged 3 commits into from
Jan 23, 2025
Merged

feat: support configuring multiple hosts when creating a cluster #90

silenceqi merged 3 commits into from
Jan 23, 2025

Conversation

@silenceqi
Copy link
Contributor

@silenceqi silenceqi commented Jan 17, 2025 •
edited
Loading

What does this PR do

support configuring multiple hosts when creating a cluster

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

@silenceqi silenceqi requested review from medcl and yaojp123 and removed request for yaojp123 January 17, 2025 10:22
@silenceqi silenceqi changed the title feat: support configuring multiple hosts when creating a cluster WIP:feat: support configuring multiple hosts when creating a cluster Jan 21, 2025
@silenceqi silenceqi changed the title WIP:feat: support configuring multiple hosts when creating a cluster feat: support configuring multiple hosts when creating a cluster Jan 22, 2025
@silenceqi silenceqi requested a review from luohoufu January 22, 2025 03:36
luohoufu
luohoufu approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@luohoufu luohoufu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silenceqi silenceqi merged commit f3417ee into main Jan 23, 2025
5 of 6 checks passed
@silenceqi silenceqi deleted the multi-hosts branch January 23, 2025 01:04
@silenceqi silenceqi mentioned this pull request Jan 23, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@medcl medcl medcl approved these changes

@luohoufu luohoufu luohoufu approved these changes

@yaojp123 yaojp123 Awaiting requested review from yaojp123

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@silenceqi @medcl @luohoufu